Skip to main content

Pull Request

Creating a Pull Request

  • Small pull request is much preferred to a large one
  • Make sure your branch is up-to-date with the base branch
  • Be descriptive in the pull request description
  • At the minimum, request a review from the team that owns the repo
  • Don't let the pull request sit out there too long. If nobody reviews your PR, follow up with your team members or the repo owner

Reviewing Pull Requests

  • Every developer at any level is encourage to review a pull request
  • Be professional and kind when reviewing the pull request
  • Once merged, delete the working branch